search

Raptor007 / aq2-tng

Action Quake 2: The Next Generation. Raptor007's sandbox for testing changes. When verified stable, this code is pushed to the official aq2-tng repo:
https://github.com/aq2-tng/aq2-tng/tree/bots
4 stars 2 forks source link

PF_cprintf to a free/zombie client #52

Closed Raptor007 closed 7 years ago

Raptor007 commented 7 years ago

When clients disconnect, the server log often says something like PF_cprintf to a free/zombie client 0.

Raptor007 commented 7 years ago

Might need if(!silent) here: https://github.com/Raptor007/aq2-tng/blob/f99b5b49e0f31ed257d50b92b2411a873d4fe1ad/source/a_vote.c#L1673 It should probably also be modified to allow removing invalid subjects.

Raptor007 commented 7 years ago

This was a problem in the bots branch. It replaced gi.bprintf with safe_bprintf which would call gi.cprintf for each non-bot player entity. However, this was unnecessary because gi.bprintf already avoids sending to bots. Fixed: https://github.com/Raptor007/aq2-tng/commit/ac630271ce6f0b154b8eca89f23c237165504529