search

Raptor007 / aq2-tng

Action Quake 2: The Next Generation. Raptor007's sandbox for testing changes. When verified stable, this code is pushed to the official aq2-tng repo:
https://github.com/aq2-tng/aq2-tng/tree/bots
4 stars 2 forks source link

Investigate and clean up "ctf 2" code #67

Closed Raptor007 closed 1 week ago

Raptor007 commented 6 years ago

There are a couple of places that refer to ctf->value == 2: https://github.com/Raptor007/aq2-tng/blob/1c5aad1a9dc79c545df4088582b93f2d4058dfc9/source/p_weapon.c#L438 https://github.com/Raptor007/aq2-tng/blob/1c5aad1a9dc79c545df4088582b93f2d4058dfc9/source/p_weapon.c#L390

But as far as I can tell, it would never be 2 anymore: https://github.com/Raptor007/aq2-tng/blob/1c5aad1a9dc79c545df4088582b93f2d4058dfc9/source/g_spawn.c#L880

This is just for code cleanup, not to address any bugs that I know of.

Raptor007 commented 1 week ago

It appears ctf 2 was an experiment to allow respawning item pickups in CTF, overriding some of the teamplay behavior that would interfere with that (such as grenade pickup checking for bandolier). Most likely it was never finished, hence the cvar_forceset to prevent trying to use it by mistake.

Closing for now because there's really no issue here.