search

Raptor123471 / DingoLingo

A Discord music bot written in Python with support for Youtube, SoundCloud, Spotify, Bandcamp, Twitter, and custom files.
GNU General Public License v3.0
282 stars 165 forks source link

Queue command format and Auto-Announce feature #71

Open Nyhilo opened 2 years ago

Nyhilo commented 2 years ago

I did a reformat on the queue command to make it more compact and to give a bit more info (such as playtimes). Looks like this: image

I also added a configurable feature that auto-announces when a new song starts playing. Useful for people to see what's on deck at a glance without having to do $np image

Nyhilo commented 2 years ago

This PR also resolves issue #40.

I'm not well practiced in contributing the code I write, so let me know if you need anything from me @Raptor123471.

Raptor123471 commented 2 years ago

I have not had a chance to run this yet but it looks great. My only suggestion right now is that the auto announce configuration in config.py becomes a setting in settings.py so that it can become configurable per guild. I will test your PR out when I get the chance.

Nyhilo commented 2 years ago

Yeah I can do that. I was little unclear about how settings.py is organized, but I've got some time this afternoon to work on it.

Nyhilo commented 2 years ago

I did the move from the config to settings.py, and I resolved the merge conflicts.

However, it seems like an existing settings.json value doesn't actually take the new setting until you run set announce_tracks true once, even though upgrade() runs. Not sure why

Raptor123471 commented 2 years ago

That's a mistake on my part where the missing keys are found and set in memory but never written to disk in the 'upgrade' function. I will push the fix and then we can get this PR merged. Check out #72 . I'm going to test it some more when I am home.