Raptor3um / raptoreum

MIT License
317 stars 134 forks source link

Support for unicode in the AppData path #265

Open paalg opened 1 year ago

paalg commented 1 year ago

To report critical security issues, DM the Core or Developer Teams instead of creating Github issues.

Describe the issue

I've had multiple errors lately, then I upgraded to version 1.3.17.01-c136d2b, and the application fails to start. I realized the application now does not support unicode in the path to the AppData\Roaming. Now I have a new folder under C:\Users\ with my name with � symbols where there should be å and æ:

C:\Users\P�l S�ter\AppData\Roaming\RaptoreumCore insted of C:\Users\Pål Sæter\AppData\Roaming\RaptoreumCore

What version of Raptoreum Core are you using?

1.3.17.01-c136d2b (upgraded from v1.2 something)

Machine specs:

Bigpiggy01 commented 1 year ago

Hi there, I am not able to reproduce that. Do you have any odd language packs installed? And was it installed with escalated priviliges?

paalg commented 1 year ago

I am not aware I have any odd language packs installed, I have a normal Windows 10 installed with Norwegian language. But the Raptoreum Core app is english. I don't remember if I used selected high privileges when installing.

I got problems synchronizing blocks, and ended up upgrading from version 1.2 to 1.3.17.01-c136d2b. It might be the function rebuilding block database that is the problem.

I get this error when I open the app now: "Error opening black database. Do you want to rebuild the block database now? [OK] [Abort]" If i click OK, I get a new error "Error opening block database [OK]", and clicking OK just closes the app. If I instead choose Abort, then the app just closes.

If the files created now gives any help, I attached the list of files from command C:\Users\P�l S�ter\AppData\Roaming\RaptoreumCore>dir /A /S files.txt

Blueskys379 commented 1 year ago

You will want to apply the bootstrap. Download one of the versions of the 1.3.17.00-01 bootstrap without the index and follow these steps.

How to bootstrap

On https://bootstrap.raptoreum.com/
Download the version of the bootstrap that matches your current wallet version. Use bootstrap version that matches your wallet version

paalg commented 1 year ago

From this clean install it still recreates the RaptoreumCore folder in both places, so parts of that version cannot handle the special characters in the users path.

The folders created where it cannot handle special characters might indicate where the problem lies: image

Bigpiggy01 commented 1 year ago

Looks like your default system language set to other than English, that shouldn't matter though as it works just fine on Danish with æøå in there.

The only circumstance I can break this under is having system set to Danish but running Mandarin during installation but that nukes unicode through out and has been an MS issue since Win 3.0 afaik.

Bigpiggy01 commented 1 year ago

Interesting, I can reproduce this on the latest release with the installer.exe still not with the stand alone binaries.

paalg commented 1 year ago

Interesting, I can reproduce this on the latest release with the installer.exe still not with the stand alone binaries.

Yes, I can confirm I used the executable installer myself