search

Rare-Technology / FMA_Dashboard

Fisheries Management Assessment Tool
https://portal.rare.org/en/tools-and-data/fma/
MIT License
0 stars 1 forks source link

Make CPUE consistent with other plots #13

Closed zross closed 3 years ago

zross commented 3 years ago

@abelvaldivia it looks like you have the trend line colored for the trend in all plots except CPUE where the points are the color. Can I change this to be consistent? This way we'll have consistent plots for quite a few.

Also, for CPUE you're using the transaction date instead of yearmonth in CPUE. Can I use yearmonth here also so we have complete consistency?

abelvaldivia commented 3 years ago

Yes for the trend line color and Yes for using yearmonth for CPUE and Total landings

zross commented 3 years ago

Cool!

zross commented 3 years ago

Actually, as I look at CPUE there are a few differences (grouping by fisher_id and then summarizing twice so perhaps it's not quite as consistent as I thought, but I'll do these.

abelvaldivia commented 3 years ago

The plotting of the x axis will be the same thought. What we would like to add/request is a choice of plotting by month (year month), by week, and by day for all indicators.

zross commented 3 years ago

Yes, we should open as a new issue. I've created a single plot that can be used for several of these plots but CPUE is different enough that it would take a bit of work to use that same function. We can discuss.

abelvaldivia commented 3 years ago

will do