Constant ASC is used one level lower than defined

Rareloop / lumberjack-core

MIT License

38 stars 20 forks source link

Open szepeviktor opened 4 years ago

szepeviktor commented 4 years ago

Used in Contracts\QueryBuilder interface, defined in QueryBuilder

How could that be fixed?

joelambert commented 3 years ago

@szepeviktor good spot, any suggestions?

szepeviktor commented 3 years ago

@joelambert I don't dare to say software design in a GitHub issue. Sorry.

szepeviktor commented 3 years ago

I may do more harm than good. Maybe an interface should not have default values for parameters.