search

Rareloop / lumberjack

Lumberjack is a powerful MVC framework for the modern WordPress developer. Write better, more expressive and easier to maintain code.
https://lumberjack.rareloop.com
MIT License
377 stars 34 forks source link

Ignore vendor folder for standalone dev installs #15

Closed haswalt closed 5 years ago

haswalt commented 6 years ago

(Thanks for sending a pull request! Please make sure you read the contribution guidelines, then fill out the blanks below.)

What does this implement/fix? Explain your changes.

When setting up lumberjack as a separate packaged theme the vendor folder should be ignored.

Does this close any currently open issues?

…

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

…

haswalt commented 5 years ago

no interest?

adamtomat commented 5 years ago

Thanks for the poke @haswalt, would you mind providing a little information about how you have Lumberjack setup in this instance?

Is it a standard WordPress install with Lumberjack core brought in using composer in the theme?

haswalt commented 5 years ago

Hi @adamtomat,

Because we use docker and continuous delivery we build theme releases separately to the wordpress core release. Currently we use bedrock with the theme installed using composer, along with plugins.

adamtomat commented 5 years ago

@haswalt We've rolled this into some updates we did today - specifically this commit: https://github.com/Rareloop/lumberjack/commit/5818d00e4bbb23eb6706195fa7ab75f045640ebe

Hope this resolved the issue for you. Thanks for being patient with us.