search

Rareloop / lumberjack

Lumberjack is a powerful MVC framework for the modern WordPress developer. Write better, more expressive and easier to maintain code.
https://lumberjack.rareloop.com
MIT License
371 stars 34 forks source link

PHP8 Compatibility #35

Closed lmartins closed 1 year ago

lmartins commented 1 year ago

With some hosts now forcing, and perhaps rightfully so, PHP8 on hosted applications it has become something you can't get around.

Unfortunately Lumberjack is still throwing fatal errors when you try to run it over PHP8.

The one immediately apparent for me is:

Fatal error: During inheritance of SessionHandlerInterface: Uncaught ErrorException: Return type of Rareloop\Lumberjack\Session\FileSessionHandler::open($savePath, $sessionName) should either be compatible with SessionHandlerInterface::open(string $path, string $name): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in

Looking at the project activity I've noticed that the last commit was in 2021, more than 1 year ago. There is no announcement about the project being abandoned, so one has to wonder if it will continued to be maintained.

Could the authors provide some context here so people know what to expect?

lmartins commented 1 year ago

Closing this as irrelevant and a result of myself misreading the situation. The package on Composer is already compatible with PHP8. The lack of updates on this repo was what led me to think there wasn't yet a version available, but that it isn't the case. Apologies for that.