search

Rari-Capital / fuse-v1

Smart contracts for Fuse V1 by Rari Capital.
Other
3 stars 3 forks source link

Adding Slither to CI #22

Closed pedrommaiaa closed 2 years ago

pedrommaiaa commented 2 years ago

WIP #20

Slither and a Github code scanning integration were added to ci.yml.

Slither is currently failing with error:ERROR:CryticCompile:Solidity version not found: No solc version set.

pedrommaiaa commented 2 years ago

Apparently slither-action@v0.1.1 doesn't work with Foundry, will change to slither-action@main, as described here.

pedrommaiaa commented 2 years ago

Slither now returns the following: crytic_compile.platform.exceptions.InvalidCompilation: Could not find the cache/solidity-files-cache.json file.If you are using 'cache = true' in foundry's config file, please remove it.

cache is already set to false in foundry.toml, will be investigating the issue.

pedrommaiaa commented 2 years ago

It's an error with forge, add an issue here.

zerosnacks commented 2 years ago

@pedrommaiaa thanks for looking into this!

zerosnacks commented 2 years ago

I noticed Foundry is planning to integrate it in their template, could be a good reference: https://github.com/foundry-rs/forge-template/pull/49

pedrommaiaa commented 2 years ago

Let's keep an eye on both PRs, should work after they are both solved/merged.