search

Rari-Capital / fuse-v1

Smart contracts for Fuse V1 by Rari Capital.
Other
3 stars 3 forks source link

Add global borrow pause override to comptroller #25

Closed sriyantra closed 2 years ago

sriyantra commented 2 years ago

Option for reopening fuse pools

sriyantra commented 2 years ago

https://github.com/Rari-Capital/fuse-v1/tree/feature/global-pause-borrows-override

sriyantra commented 2 years ago

@zerosnacks please review. We just need to ensure no state corruption upon upgrade

zerosnacks commented 2 years ago

Reviewed, left some minor comments. I was a bit confused at first. On the outset I don't see any way this would cause a state corruption.

Is there a recommended way we could verify that this does not cause state corruption?

Perhaps a mainnet fork and then a Hardhat deployment script with basic verification checks?

sriyantra commented 2 years ago

could really just do a foundry deployment with simple checks. But yea this shouldn't alter state in any way