search

Rari-Capital / fuse-v1

Smart contracts for Fuse V1 by Rari Capital.
Other
3 stars 3 forks source link

Run linter across entire codebase #32

Closed zerosnacks closed 2 years ago

zerosnacks commented 2 years ago

Due to an earlier mistake (not adding single quotes around the path, thus not properly globbing) the linter did not run across the entire codebase correctly.

zerosnacks commented 2 years ago

PR: https://github.com/Rari-Capital/fuse-v1/pull/31

zerosnacks commented 2 years ago

It is important to realize that whilst linters are very useful in making our codebase more comprehensive it could increase complexity and auditing time of diffing with the original Compound codebase.

There is also a minor risk we introduce by using autoformatting linters in that we could possibly introduce an incompability with an older version of Solidity if the linter is not configured correctly.

See: https://github.com/prettier-solidity/prettier-plugin-solidity#compiler-experimental

zerosnacks commented 2 years ago

@sriyantra would be great if you could review #31 (see comment about stack error introduced by Prettier) and would be interesting to hear what you think about this.

I've used Prettier extensively on TypeScript codebases and never ran into issues there.

zerosnacks commented 2 years ago

Merged