search

Rari-Capital / fuse-v1

Smart contracts for Fuse V1 by Rari Capital.
Other
3 stars 3 forks source link

Consider a retry solution, fallback solution or paid plan for CI mainnet forking #35

Closed zerosnacks closed 2 years ago

zerosnacks commented 2 years ago

I noticed concurrent API limits were being hit on Alchemy causing tests to fail (https://github.com/Rari-Capital/fuse-v1/runs/6577591398?check_suite_focus=true#step:7:396 / https://github.com/Rari-Capital/fuse-v1/runs/6577970227?check_suite_focus=true#step:7:396) . It currently uses my free personal API key so if we keep experiencing issues with it we may want to bump it to a professional plan for the organization.

For now if you expect your test to be passing feel free to manually re-run the CI action.

zerosnacks commented 2 years ago

Relevant tweet: https://twitter.com/gakonst/status/1529802263824322562

Support is coming to Foundry to rate limit test fetching from node providers because more people are having this issue

zerosnacks commented 2 years ago

Basically blocked until above mentioned fix is implemented

The total calls to the node provider are relatively low so no need for a pro-plan other than if it would work around the minute rate-limit

zerosnacks commented 2 years ago

Unblocked

Luckily for us this got merged into the latest Foundry release https://twitter.com/gakonst/status/1529824204350058501

If I understand this correctly it should not require changes on our end.

zerosnacks commented 2 years ago

Can be closed once we verify when a test run stop failing because of rate limit errors

zerosnacks commented 2 years ago

Ran a development and master workflow at the same time and it did not fall over. For now I think its good enough to close the ticket.