Rari-Capital / fuse-v1

Smart contracts for Fuse V1 by Rari Capital.
Other
3 stars 3 forks source link

Import Compound-Protocol (fuse-reactive-audit) and Fuse Contracts (v1.2.3) #7

Closed zerosnacks closed 2 years ago

zerosnacks commented 2 years ago

Notes:

I've decided to change the interface imports after chatting with @sriyantra - the interface itself now does not start with an I but the filename does.

To do:

Make sure we apply the other branches that are currently outstanding on top

sriyantra commented 2 years ago

Notes:

I've decided to change the interface imports after chatting with @sriyantra - the interface itself now does not start with an I but the filename does.

To do:

Evaluate which files are not necessary anymore or are unused

  • core/Governance/*
  • core/Lens/*
  • core/IFuseFeeDistributor.sol (should import from root)
  • utils/InitializableClones.sol
  • Migrations.sol

Evaluate if we need the interface specific for each liquidator and price oracle.

Evaluate if we want to include the ABI (could be useful for the rari-sdk)

Make sure we apply the other branches that are currently outstanding on top

I think /Governance, /Lens, and Migrations.sol can be removed. InitializableClones may be relevant to simulate deployments of ctokens and comptrollers. ABI could be useful. Oracles should have the same general interface, with the exception that some have additional admin type functions or setup functions to initialize new assets being used.

zerosnacks commented 2 years ago

Any issues I've found along the way I've created separate tickets for:

11, #10 , #9 , #8

zerosnacks commented 2 years ago

Merging this - please keep in mind we likely have merge conflicts with deleted accounting fix on top - will resolve that when we decide to merge the fix.

zerosnacks commented 2 years ago

I've deleted the aforementioned files from the repo excluding Initialiazable clone, generated the interfaces specific for each oracle and liquidator (including ABI).