Closed sharad-s closed 3 years ago
@sharad-s is attempting to deploy a commit to the Rari Capital Team on Vercel.
A member of the Team first needs to authorize it.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/components/pages/Fuse/FusePoolEditPage.tsx | 0 | 1 | 0.0% | ||
src/components/pages/PoolPortal.tsx | 0 | 1 | 0.0% | ||
src/components/pages/Tranches/TranchesPage.tsx | 0 | 1 | 0.0% | ||
src/components/pages/Fuse/FusePoolPage.tsx | 0 | 2 | 0.0% | ||
src/components/pages/Pool2/Pool2Page.tsx | 0 | 2 | 0.0% | ||
src/hooks/useAuthedCallback.ts | 4 | 7 | 57.14% | ||
src/components/shared/AccountButton.tsx | 7 | 13 | 53.85% | ||
src/context/RariContext.tsx | 2 | 12 | 16.67% | ||
<!-- | Total: | 14 | 40 | 35.0% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/components/pages/Fuse/FusePoolEditPage.tsx | 1 | 0% | ||
src/components/pages/Tranches/TranchesPage.tsx | 1 | 0% | ||
src/hooks/useTVL.ts | 1 | 83.33% | ||
src/rari-sdk/pools/stable.js | 1 | 4.08% | ||
src/utils/bigUtils.ts | 1 | 66.67% | ||
src/utils/shortAddress.ts | 1 | 0% | ||
src/components/pages/Fuse/FusePoolPage.tsx | 2 | 0% | ||
src/components/pages/MultiPoolPortal.tsx | 5 | 60.16% | ||
src/context/RariContext.tsx | 6 | 36.94% | ||
src/rari-sdk/governance.js | 7 | 21.57% | ||
<!-- | Total: | 59 | --> |
Totals | |
---|---|
Change from base Build 793670225: | -0.9% |
Covered Lines: | 707 |
Relevant Lines: | 4851 |
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/rari-capital/rari/EFNSiQzwsmsruW78FFXptAb6RWwj
✅ Preview: https://rari-git-fork-sharad-s-sharad-s-manual-connect-rari-capital.vercel.app
Awesome looks great.
two last things:
can we add a spinner to the "Connect" button as it's loading the modal? It's sometimes very slow on first load because of how bloated it is (not your fault) 😅
can we also make the connect button the same width as the account button so it stands out more and has less layout shift?
Awesome looks great.
two last things:
* can we add a spinner to the "Connect" button as it's loading the modal? It's sometimes very slow on first load because of how bloated it is (not your fault) 😅 * can we also make the connect button the same width as the account button so it stands out more and has less layout shift?
👌
Summary
This PR removes the requirement to have web3 installed to browse the Rari dApp. All defi actions are gated behind web3 auth. This is useful so that anyone can browse the app regardless of whether they have access to Web3.
Changes
useAuthedCallback
which will wrap any function in an auth checkopenModal
functions in theuseAuthedCallback
hook - you cannot interact with defi modals unless logged in.Demo