Rari-Capital / rari-dApp

Rari Capital's Web3 Portal.
https://app.rari.capital
GNU Affero General Public License v3.0
151 stars 69 forks source link

Fix interest rates comparison page #445

Closed zane-programs closed 3 years ago

zane-programs commented 3 years ago

Hey y'all!

Sorry for my relative inactivity in the past few weeks—I had been doing a summer program until last Friday, and since then I've been getting my college applications and SATs in order.

Anyway, I noticed that the interest rate comparison page did not display Fuse rates because one of the pools returns the following error: Returned error: execution reverted: borrow rate is absurdly high.

I just made a super quick fix to the error handling in the useFuseMarkets() hook, and rates for the other pools appear successfully.

vercel[bot] commented 3 years ago

@zane-programs is attempting to deploy a commit to the Rari Capital Team on Vercel.

A member of the Team first needs to authorize it.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1098880858


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/pages/Fuse/FuseLiquidationsPage.tsx 0 2 0.0%
src/components/shared/PoolsPerformance.tsx 2 7 28.57%
src/hooks/interestRates/fuse/useFuseMarkets.ts 0 5 0.0%
src/rari-sdk/pools/ethereum.js 2 8 25.0%
<!-- Total: 7 25 28.0% -->
Files with Coverage Reduction New Missed Lines %
src/components/pages/Fuse/FuseLiquidationsPage.tsx 1 0%
src/components/pages/MultiPoolPortal.tsx 1 52.76%
src/components/shared/ClaimRGTModal.tsx 1 53.23%
src/components/shared/PoolsPerformance.tsx 1 29.79%
src/utils/bigUtils.ts 1 44.44%
src/rari-sdk/pools/ethereum.js 2 15.87%
src/rari-sdk/subpools/aave.js 3 11.76%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 1050849215: -0.09%
Covered Lines: 860
Relevant Lines: 5791

💛 - Coveralls