search

Rari-Capital / rari-dApp

Rari Capital's Web3 Portal.
https://app.rari.capital
GNU Affero General Public License v3.0
151 stars 69 forks source link

clean up rari multisigs in rss #448

Closed 0xDaksh closed 2 years ago

vercel[bot] commented 2 years ago

@DakshMiglani is attempting to deploy a commit to the Rari Capital Team on Vercel.

A member of the Team first needs to authorize it.

transmissions11 commented 2 years ago

Thanks!

transmissions11 commented 2 years ago

Wait @DakshMiglani can you make a follow up to use .includes instead of index of? 🙏

0xDaksh commented 2 years ago

done #449 @transmissions11

transmissions11 commented 2 years ago

Oh and I should probably explicitly comment that all the addresses in the rariMultisigs list need to be all lowercase

0xDaksh commented 2 years ago

Or maybe we can just do a map(x => x.toLowerCase())

transmissions11 commented 2 years ago

Or maybe we can just do a map(x => x.toLowerCase())

Yeah I like that! Can we use the web3 toChecksumAddress instead of toLowerCase tho? 😅🙏