Rarst / fragment-cache

WordPress plugin for partial and async caching.
Other
140 stars 10 forks source link

Parse error: syntax error, unexpected end of file in fragment_cache.php on line 161 #1

Closed postme closed 10 years ago

postme commented 10 years ago

line 146: <?

should be:

<?php

Rarst commented 10 years ago

You are reporting in the wrong repository. :) That's different plugin.

postme commented 10 years ago

I see now what went wrong, it looks like there is a naming collision with your fragment cache plugin and a similarly named plugin in the wordpress repository. I installed your plugin trough composer and subsequently got the message in wp-admin that your plugin needed upgrading, which I did. This upgrade removes your plugin and installs the other fragmentcache plugin, with the coding error.

Rarst commented 10 years ago

Ugh, yes, that. Unfortunately only so much I can do about repository serving stupid updates. :( I will get to adding code that opts out, but that still only works as long as plugin turned on and running.

postme commented 10 years ago

No worries, just wanted to clarify I wasn’t completely off my rocker :)

I’ll certainly give your plugin a good spin, starting up BlazeMeter load tests tonight to get a feeling for the performance impact, happy to share if you’re interested?

Rarst commented 10 years ago

Very much so! Happy for any (good and bad) feedback, keep it coming! :)

postme commented 10 years ago

Hi Andrey,

Please find attached the blazemeter test I did tonight with a baseline reference. Dark green is with fragment_cache and light green is plain vanilla. It is a wordpress site with a genesis theme.

Test is maximum stress with 50 concurrent users for 1 hour duration.

Number of concurrent users is increased at an accelerated rate.

Server is overwhelmed.

5 minute user ramp up.

35 minute continuous load.

Looks like fragment caching shaves of 100 ms in this scenario

Rarst commented 10 years ago

I don't think GitHub issues handle attachments, you'll have to post via site or email me directly. :)