Raruto / leaflet-elevation

Leaflet plugin that allows to add elevation profiles using d3js
GNU General Public License v3.0
255 stars 85 forks source link

Map and other elements not showing with iOS 15.4 #203

Closed pizerodev closed 2 years ago

pizerodev commented 2 years ago

On iOS 15.4, maps do not appear correctly

See screenshot taken on this page: https://raruto.github.io/leaflet-elevation/examples/leaflet-elevation.html I found this as a project I'm using which uses elevation with gpx files, was showing the same on my app.

Many of the examples shown in the home page are affected.

error Tested on: iPhone 13 Pro (Simulator)

hupe13 commented 2 years ago

Does it work with leaflet V 1.8.0?

Raruto commented 2 years ago

Hi @pizerodesign and @hupe13,

I also did a test with browserstack.com and I think it is more a problem related to leaflet-ui and the leaflet.fullscreen control.

leaflet-ui.js:21 TypeError: undefined is not an object (evaluating 'this._screenfull.raw.fullscreenchange')

Take a look here if you want to see this bug fixed: https://github.com/brunob/leaflet.fullscreen/issues/99

Have a nice day, Raruto

hupe13 commented 2 years ago

I have added this pull request to hupe13/extensions-leaflet-map-github/leaflet-plugins/leaflet.fullscreen and no one has complained anymore.

Raruto commented 2 years ago

Ok @hupe13 thanks for letting me know, but to solve this it is better if you contact bruno directly (I am not going to patch here any external libraries that are still somehow supported).

Greetings, Raruto

pizerodev commented 2 years ago

Hi there,

This issue was gone for me when I changed this:

https://unpkg.com/@raruto/leaflet-elevation/dist/leaflet-elevation.css https://unpkg.com/@raruto/leaflet-elevation/dist/leaflet-elevation.js

to this

https://unpkg.com/@raruto/leaflet-elevation@1.6.9/dist/leaflet-elevation.min.css https://unpkg.com/@raruto/leaflet-elevation@1.6.9/dist/leaflet-elevation.min.js

hupe13 commented 2 years ago

(I am not going to patch here any external libraries that are still somehow supported).

That is clear. But the pull request already exists.

km37500 commented 2 years ago

Hi @pizerodesign

So if you use this example: https://raruto.github.io/leaflet-elevation/examples/leaflet-elevation.html

and change the lines:

<link rel="stylesheet" href="https://unpkg.com/@raruto/leaflet-elevation@2.2.6/dist/leaflet-elevation.min.css" />
<script src="https://unpkg.com/@raruto/leaflet-elevation@2.2.6/dist/leaflet-elevation.min.js"></script>

into

<link rel="stylesheet" href="https://unpkg.com/@raruto/leaflet-elevation@1.6.9/dist/leaflet-elevation.min.css" />
<script src="https://unpkg.com/@raruto/leaflet-elevation@1.6.9/dist/leaflet-elevation.min.js"></script>

it s not working (no height map any longer).

What is wrong?

km37500 commented 2 years ago

Hi @Raruto

I think the bug is fixed here: https://github.com/brunob/leaflet.fullscreen/pull/101#issuecomment-1151293453

Could you implement also into leaflet-elevation?

Raruto commented 2 years ago

Try to check, i updated all the examples to leaflet-ui v0.5.9

Raruto