RasPlex / OpenPHT

OpenPHT is a community driven fork of Plex Home Theater
Other
596 stars 110 forks source link

Enhancement: Option to display server name instead of user name in home listing #196

Closed Fmstrat closed 7 years ago

Fmstrat commented 7 years ago

As it stands now, if you are the owner of a server, the label 2 in the home screen listing shows the server name. However, if you are a user that library has been shared with, and you have the option to "Show shared libraries in menu" enabled, the user name of the server owner is listed as label 2 instead of the server name.

For instance, if these exist...

... then when you are logged in as Admin, you see in the menu...

... but when you are logged in as Guest, you see...

... and you can't tell which server is which. A toggle option that impacts this "if" statement:

https://github.com/RasPlex/OpenPHT/blob/openpht-1.7/plex/Home/GUIWindowHome.cpp#L733

... should do the trick, but unfortunately I'm not familiar with the code base enough at this point to execute a pull.

OpenPHT: 1.7.1, OSX (applies to all) PMS: n/a

Fmstrat commented 7 years ago

Well, this actually SEEMS pretty straight forward, though I'm not sure of the appropriate way to test this. I haven't done a pull request just in case because I don't want to muck things up, but here is a commit, only had to modify three files:

https://github.com/Fmstrat/OpenPHT/commit/c1d0baf1e39cb4c9db079b431b6efc00a373d9b4

And here is a compare for if other changes have been implemented since this was posted:

https://github.com/RasPlex/OpenPHT/compare/openpht-1.7...Fmstrat:openpht-1.7

Kwiboo commented 7 years ago

Thanks @Fmstrat, this was included in the recently released v1.8.0.148-573b6d73