The depends batch file is broken not sure how this wasn't caught a long time ago. I have been scratching my head as to why it was not pulling down the required files to build. Then I noticed these error lines I somehow missed before:
Unpacking deps...
The system cannot find the path specified.
The system cannot find the path specified.
Those errors I have found are due to the dirs never being properly created (not anything else with the "DEPENDDIR" working) nor any of the vcredist or dxupdates both obviously critical to the build.
Cause
This line:
set DEPENDDIR="%WORKSPACE%\plex\build\dependencies"
If I merely add an echo and pause after the set lines, you can clearly see that because of how it is written the double quotes break everything:
set DEPENDDIR="%WORKSPACE%\plex\build\dependencies"
@echo DEPENDDIR is %DEPENDDIR%
PRODUCES:
WORKSPACE is "D:\Github\OpenPHT\plex\scripts\..\.."
DEPENDDIR is ""D:\Github\OpenPHT\plex\scripts\..\.."\plex\build\dependencies"
So, on multiple boxes I just tested, only the xbmc tar gets handled and everything after that simply blows up since DEPENDDIR is invalid.
If I get a chance I'll just submit a PR if you want but since after a year there is still no 1.9 build posted here for all the masses waiting for fixes to even those few known issues resolved in the current 1.9 codebase, at the very least there really needs to be working build scripts/instructions so others can get it built.
I know there is supposedly this super-secret 2.0 codebase on some private repo, but it's been over a year since any binary patches/fixes for the windows client have been provided and zero communication regarding any progress, so is there any chance after this long now that in the spirit of open-source, whatever progress has been made on 2.0 can now be made public? And, is there a reason it was not shared with the public shortly after getting the first upstream new codebase from Kodi that it is based upon? Either way, can you please perhaps consider posting an update?
The depends batch file is broken not sure how this wasn't caught a long time ago. I have been scratching my head as to why it was not pulling down the required files to build. Then I noticed these error lines I somehow missed before:
Those errors I have found are due to the dirs never being properly created (not anything else with the "DEPENDDIR" working) nor any of the vcredist or dxupdates both obviously critical to the build.
Cause
This line:
If I merely add an echo and pause after the set lines, you can clearly see that because of how it is written the double quotes break everything:
PRODUCES:
So, on multiple boxes I just tested, only the xbmc tar gets handled and everything after that simply blows up since DEPENDDIR is invalid.
If I get a chance I'll just submit a PR if you want but since after a year there is still no 1.9 build posted here for all the masses waiting for fixes to even those few known issues resolved in the current 1.9 codebase, at the very least there really needs to be working build scripts/instructions so others can get it built.
I know there is supposedly this super-secret 2.0 codebase on some private repo, but it's been over a year since any binary patches/fixes for the windows client have been provided and zero communication regarding any progress, so is there any chance after this long now that in the spirit of open-source, whatever progress has been made on 2.0 can now be made public? And, is there a reason it was not shared with the public shortly after getting the first upstream new codebase from Kodi that it is based upon? Either way, can you please perhaps consider posting an update?
TIA!