RasPlex / OpenPHT

OpenPHT is a community driven fork of Plex Home Theater
Other
597 stars 109 forks source link

Fails to build, MythFile.cpp issue #328

Open FabioLolix opened 2 years ago

FabioLolix commented 2 years ago
[ 61%] Building CXX object xbmc/CMakeFiles/xbmc.dir/filesystem/ShoutcastFile.cpp.o
[ 61%] Building CXX object xbmc/CMakeFiles/xbmc.dir/filesystem/SlingboxDirectory.cpp.o
/build/openpht-git/src/openpht/xbmc/filesystem/MythFile.cpp: In member function ‘virtual bool XFILE::CMythFile::SkipNext()’:
/build/openpht-git/src/openpht/xbmc/filesystem/MythFile.cpp:521:53: error: ordered comparison of pointer with integer zero (‘cmyth_recorder_t’ {aka ‘cmyth_recorder*’} and ‘int’)
  521 |     return m_dll->recorder_is_recording(m_recorder) > 0;
      |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
[ 61%] Building CXX object xbmc/CMakeFiles/xbmc.dir/filesystem/SlingboxFile.cpp.o
[ 61%] Building CXX object xbmc/CMakeFiles/xbmc.dir/filesystem/SmartPlaylistDirectory.cpp.o
[ 61%] Building CXX object xbmc/CMakeFiles/xbmc.dir/filesystem/SourcesDirectory.cpp.o
[ 61%] Building CXX object xbmc/CMakeFiles/xbmc.dir/filesystem/SpecialProtocol.cpp.o
[ 61%] Building CXX object xbmc/CMakeFiles/xbmc.dir/filesystem/SpecialProtocolDirectory.cpp.o
make[2]: *** [xbmc/CMakeFiles/xbmc.dir/build.make:4556: xbmc/CMakeFiles/xbmc.dir/filesystem/MythFile.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:2575: xbmc/CMakeFiles/xbmc.dir/all] Error 2
make: *** [Makefile:156: all] Error 2
==> ERROR: A failure occurred in build().

Hello, I'm on Manjaro Linux and I'm revisiting the AUR pkgbuilds for openpht, building using latest commit cf23f65fd, attached there is the build log

openpht-git-1.8.0b.r0.gcf23f65fd-1-x86_64-build.log

brfransen commented 2 years ago

I have fixed this in #329

FabioLolix commented 2 years ago

Confirming that @brfransen patches are working (applied all 4), after that builds fails again with problems about CEC, disabling CEC the build pass

Side note that previously added flag -DPLIST_LIBRARY:FILEPATH=/usr/lib/libplist-2.0.so which might no longer be required