Closed tttthomasssss closed 2 years ago
Since 3.0 isn't out yet, I don't think we can merge these changes to main - it will break the bot itself for anyone who tries to clone it. Can we instead change the branch the model regression tests refer to?
Thats a great point - thank you Melinda! I'll patch the config file to run from a different branch and will leave this PR open until its safe to merge 🙂
@tttthomasssss since 3.0 is out, we can get this mergeable, but it's going to mean migrating the whole assistant to 3.0 - I think the autoconvert of the domain for slot mappings should do most of it, but we will need to check that it doesn't break anything.
Another thing I just realized 🤦♀️: Rasa X 1.0 is not compatible with Rasa OSS 3.0 yet. If we merge this the deployed version of Finbot will be unuseable.
lol, right, lets wait for another little bit then (thank you very much for the review in the meantime!)
The model regression tests have been failing on some datasets due to changes in
domain.yml
for the 3.0 release (see Slack thread here).I have run the recommended
rasa data migrate
on the domain file in order to address rasa#10041.