search

RasaHQ / helm-charts

Helm charts for Rasa products
https://rasa.com
Apache License 2.0
32 stars 29 forks source link

Duckling endpoint not passed to pod when external is True and an external URL is provided #76

Closed nyejon closed 2 years ago

nyejon commented 2 years ago

https://github.com/RasaHQ/helm-charts/blob/e7e72f4a3333cb42430c0f49d001cb7d03fdaf74/charts/rasa/templates/helpers/_duckling.tpl#L5

This results in the following: if false or (true and (not true)) resulting in false. We need this to be true when external = true and external url = true.

{{- if or .Values.duckling.install (and .Values.duckling.external.enabled .Values.duckling.external.url) -}} would be better.

This means the duckling endpoint is not provided to the pod here:

https://github.com/RasaHQ/helm-charts/blob/e7e72f4a3333cb42430c0f49d001cb7d03fdaf74/charts/rasa/templates/_containers-env.yaml#L21-L23

sara-tagger commented 2 years ago

Thanks for the issue, @yennycheung will get back to you about it soon!

You may find help in the docs and the forum, too 🤗
nyejon commented 2 years ago

One can get around this issue by manually adding to the envs of the rasa pod.:

- name: “RASA_DUCKLING_HTTP_URL”
  value: “http://{duckling_service}:8000”