search

RasaHQ / helm-charts

Helm charts for Rasa products
https://rasa.com
Apache License 2.0
31 stars 29 forks source link

ingressClassName missing from ingress #99

Open nyejon opened 2 years ago

nyejon commented 2 years ago

Hi,

The ingressClassName is missing from the helm chart and templates.

https://kubernetes.io/docs/concepts/services-networking/ingress/#the-ingress-resource

It is available in the Rasa-X chart: https://github.com/RasaHQ/rasa-x-helm/blob/87a311f92481a2f476a517fb9c80766b16696022/charts/rasa-x/values.yaml#L830

Thanks.

Kamaradeivanov commented 1 year ago

I definitly need it, I use a kubectl patch command as a workaround but please add it.

IngressClass resource and spec.ingressClassName is in stable state since Kubernetes 1.19, it's been a while.

Kamaradeivanov commented 1 year ago

I just do a proposal here : https://github.com/RasaHQ/helm-charts/pull/111

EDunstonZoo commented 1 year ago

Needed too please!

marcoadasilvaa commented 1 year ago

+1

dialonce commented 1 year ago

IngressClassName resource is the way to specify IngressClass since kubernetes 1.19 (released in 2020). PR have been done almost 6 month ago .... Please could you check the assiocated PR ?

Kamaradeivanov commented 10 months ago

Any news ? You closed my PR 6 months ago but nothing has changed since then.