search

RasaHQ / helpdesk-assistant

Apache License 2.0
185 stars 153 forks source link

Added required_slots field to form definitions. #55

Closed kedz closed 3 years ago

kedz commented 3 years ago

Currently the form definitions in the domain.yml do not use the required_slots key. Not using the key was marked as deprecated in Rasa 2.6. As we move to 3.0 and start removing deprecated behaviors, not using the required_slots keys will cause training to fail on YAML validation.

This PR adds the required_slots key to all form definitions in the domain.yml. This should not change the behavior of the bot.

erohmensing commented 3 years ago

The CI is failing because it's installing 2.1.3: https://github.com/RasaHQ/helpdesk-assistant/pull/55/checks?check_run_id=3083049106#step:5:66

The requirements will install the latest 2.0.x i believe: https://github.com/RasaHQ/helpdesk-assistant/blob/main/requirements.txt#L1

Seems like both of these should be updated, but I'm going to give this to a CSE to review :)

kedz commented 3 years ago

@akelad Is there someone else I can have review this? I think @mvielkind is out this week.

github-actions[bot] commented 3 years ago

Commit: e8322f20fc3677b6d383f483ee29180ebfe6d6d6 Data: default

Configuration Intent Classification Micro F1 Entity Recognition Micro F1 Response Selection Micro F1 Story Recognition Micro F1
config.yml 0.8402 (0.00) 0.7692 (0.00) no data 1.0000 (0.00)

Intent Cross-Validation Results

class support f1-score confused_with
macro avg 438 0.81433443553873720 N/A
weighted avg 438 0.83483220227201390 N/A
human_handoff 79 0.96153846153846150 bot_challenge(2), problem_email(1)
goodbye 41 0.86746987951807220 greet(3), help(2)
bot_challenge 36 0.92105263157894730 greet(1)
help 33 0.79487179487179480 out_of_scope(1), bot_challenge(1)
thank 32 0.85714285714285720 incident_status(1), deny(1)
out_of_scope 27 0.47619047619047616 thank(4), help(4)
greet 27 0.72727272727272730 help(3), goodbye(3)
affirm 27 0.81632653061224490 thank(2), greet(2)
deny 24 0.84444444444444440 inform(1), human_handoff(1)
inform 23 0.71428571428571430 out_of_scope(2), incident_status(2)
open_incident 23 0.84000000000000000 inform(1), help(1)
password_reset 22 1.00000000000000000 N/A
problem_email 22 0.81818181818181820 out_of_scope(2), open_incident(1)
incident_status 22 0.76190476190476200 open_incident(4), inform(2)

Entity Cross-Validation Results

entity support f1-score precision recall
priority 16 0.7692307692307693 1 0.625
micro avg 16 0.7692307692307693 1 0.625
macro avg 16 0.7692307692307693 1 0.625
weighted avg 16 0.7692307692307693 1 0.625
akelad commented 3 years ago

@b-quachtran before approving these before we need to make sure we've actually upgraded helpdesk-assistant.rasa.com to the newest version, it's currently in a broken state 😅

b-quachtran commented 3 years ago

@akelad Oh, I completely forgot about the hosted instance. I'll get on upgrading to 0.42.0 as soon as the image is released