Closed juandes closed 4 years ago
Hi! In this PR, I propose adding a Pokemon dataset JSON file to the data directory. The reasoning behind adding this file is that it could allow us to perform more complicated queries regarding the Pokemon.
The file was obtained from here: https://www.kaggle.com/rajgaurav9/pokemon-stats-and-description-with-pictures-json
However, I slightly modified the JSON to have the Pokemon names as keys, in case we need to do a quick lookup.
@koaning in issue #5, you mentioned your idea of hosting the images somewhere. So, I'll leave that to you.
Below is an example of a Pokemon:
{ "Bulbasaur": { "id": "001", "name": "Bulbasaur", "species": "Seed Pokemon", "type": [ "Grass", "Poison" ], "height": "2ft.4in. (0.71m)", "weight": "15.2 lbs (6.9 kg)", "abilities": [ "Overgrow", "Chlorophyll" ], "stats": { "hp": 45, "attack": 49, "defense": 49, "sp.atk": 65, "sp.def": 65, "speed": 45, "total": 318 }, "evolution": [ "Bulbasaur", "Ivysaur", "Venusaur" ], "description": "For some time after its birth, it grows by gaining nourishment from the seed on its back.", "gen": 1 },
This is a pretty epic PR. Thanks!
Thanks for accepting it :D
Hi! In this PR, I propose adding a Pokemon dataset JSON file to the data directory. The reasoning behind adding this file is that it could allow us to perform more complicated queries regarding the Pokemon.
The file was obtained from here: https://www.kaggle.com/rajgaurav9/pokemon-stats-and-description-with-pictures-json
However, I slightly modified the JSON to have the Pokemon names as keys, in case we need to do a quick lookup.
@koaning in issue #5, you mentioned your idea of hosting the images somewhere. So, I'll leave that to you.
Below is an example of a Pokemon: