RasaHQ / rasa-sdk

SDK for the development of custom actions for Rasa
https://rasa.com/docs
Apache License 2.0
292 stars 233 forks source link

Housekeeping, Sprint 48 #1008

Closed vcidst closed 1 year ago

vcidst commented 1 year ago

Proposed changes:

There are no changes needed in pyproject.toml for the following so I'll be closing these PRs after updating the poetry.lock file with poetry update ruamel-yaml typing-extensions requests,

Status (please check what you already did):

vcidst commented 1 year ago

@ancalita As per your comment here, how should I test that updating prompt-toolkit doesn't break commands in rasa-oss?

ancalita commented 1 year ago

@ancalita As per your comment here, how should I test that updating prompt-toolkit doesn't break commands in rasa-oss?

I think this needs to be tested on a rasa-oss branch where you pin rasa-sdk branch to this branch. Then you test rasa interactive. Let me try to dig around Slack to see if i can find more details beyond my faded memories 😆

ancalita commented 1 year ago

@vcidst Managed to find this PR that describes that the prompt toolkit upgrade was breaking unit tests in rasa-oss (with a link to submitted ticket in prompt-toolkit repo). It seems that beyond testing rasa shell and rasa interactive we need to be careful CI passes on OSS end as well. Hope this helps!

vcidst commented 1 year ago

@ancalita Thank you for the insight! I'll leave prompt-toolkit out of this housekeeping PR in that case and create a ticket to update it

https://rasahq.atlassian.net/browse/ATO-1303