Closed vcidst closed 1 year ago
@ancalita As per your comment here, how should I test that updating prompt-toolkit doesn't break commands in rasa-oss?
@ancalita As per your comment here, how should I test that updating prompt-toolkit doesn't break commands in rasa-oss?
I think this needs to be tested on a rasa-oss branch where you pin rasa-sdk branch to this branch. Then you test rasa interactive
. Let me try to dig around Slack to see if i can find more details beyond my faded memories 😆
@vcidst Managed to find this PR that describes that the prompt toolkit upgrade was breaking unit tests in rasa-oss (with a link to submitted ticket in prompt-toolkit repo). It seems that beyond testing rasa shell
and rasa interactive
we need to be careful CI passes on OSS end as well. Hope this helps!
@ancalita Thank you for the insight! I'll leave prompt-toolkit out of this housekeeping PR in that case and create a ticket to update it
Proposed changes:
There are no changes needed in
pyproject.toml
for the following so I'll be closing these PRs after updating thepoetry.lock
file withpoetry update ruamel-yaml typing-extensions requests
,Status (please check what you already did):
black
(please check Readme for instructions)