search

RasaHQ / rasa-sdk

SDK for the development of custom actions for Rasa
https://rasa.com/docs
Apache License 2.0
291 stars 233 forks source link

Add support for ARM arch for rasa-sdk Docker images #1123

Closed ancalita closed 4 months ago

ancalita commented 4 months ago

Proposed changes:

Status (please check what you already did):

radovanZRasa commented 4 months ago

@ancalita could you temporary modify rasa-sdk-dev-docker-image.yml so that it executes on this PR so that we can verify that image is pushed to AWS and we can examine it and confirm that it is multi-platform?

ancalita commented 4 months ago

@ancalita could you temporary modify rasa-sdk-dev-docker-image.yml so that it executes on this PR so that we can verify that image is pushed to AWS and we can examine it and confirm that it is multi-platform?

Sure, great idea, I was also wondering what would be the best way to test this @radovanZRasa

ancalita commented 4 months ago

@radovanZRasa @sanchariGr the dev image for this PR was pushed to AWS, my work laptop is an Intel and I also don't know how to access the AWS registry, could any of you test this please?

radovanZRasa commented 4 months ago

I can confirm that the fix works. Verified by running:

docker pull 329710836760.dkr.ecr.us-east-1.amazonaws.com/rasa-sdk-dev:latest
docker inspect 329710836760.dkr.ecr.us-east-1.amazonaws.com/rasa-sdk-dev:latest

Resulting response:

[
    {
        "Id": "sha256:07f97f4eef06a60ad980cc5ca78c42261bdd45b2a9ab9345fb4a49ead7cec5c5",
        "RepoTags": [
            "329710836760.dkr.ecr.us-east-1.amazonaws.com/rasa-sdk-dev:latest"
        ],
        "RepoDigests": [
            "329710836760.dkr.ecr.us-east-1.amazonaws.com/rasa-sdk-dev@sha256:1ee639c7a668062b71ed211cc8a328bc9ea598725a12cbbec936d9405f82e35b"
        ],
        "Parent": "",
        "Comment": "buildkit.dockerfile.v0",
        "Created": "2024-07-09T11:08:08.370905933Z",
        "DockerVersion": "",
        "Author": "",
        "Config": {
            "Hostname": "",
            "Domainname": "",
            "User": "1001",
            "AttachStdin": false,
            "AttachStdout": false,
            "AttachStderr": false,
            "ExposedPorts": {
                "5055/tcp": {}
            },
            "Tty": false,
            "OpenStdin": false,
            "StdinOnce": false,
            "Env": [
                "PATH=/opt/venv/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
            ],
            "Cmd": [
                "start",
                "--actions",
                "actions"
            ],
            "ArgsEscaped": true,
            "Image": "",
            "Volumes": null,
            "WorkingDir": "/app",
            "Entrypoint": [
                "./entrypoint.sh"
            ],
            "OnBuild": null,
            "Labels": {
                "org.opencontainers.image.ref.name": "ubuntu",
                "org.opencontainers.image.version": "22.04"
            },
            "Shell": [
                "/bin/bash",
                "-o",
                "pipefail",
                "-c"
            ]
        },
        "Architecture": "arm64",
        "Os": "linux",
        "Size": 243869341,
        "GraphDriver": {
            "Data": {
                "LowerDir": "/var/lib/docker/overlay2/0af3848c8d2ab8882b9e3e768308b976efa6d9910c2e5bac689c46512970076d/diff:/var/lib/docker/overlay2/3a9857f56536d3c2f073788d92b0b1354336fc7c035d33cb05c7e496f3cd31f7/diff:/var/lib/docker/overlay2/9175c7373065d17277714af8a34644bd4f8b59255de0cf7d9ffbb973e726ed64/diff:/var/lib/docker/overlay2/337ea8289403a591fe127dd7fc8fb7c260c81c39cf038b3ac1d9f38d5fd5d9ec/diff:/var/lib/docker/overlay2/1cd39ddc169b9acf8be84d3b09db5f1ffd6e4c5a08692d21531d7bf746618184/diff:/var/lib/docker/overlay2/f29e8af8a124702d9c06b9b41e4b858fc8e681a1b42373de6f6bd06b853ef789/diff",
                "MergedDir": "/var/lib/docker/overlay2/64ff7d647da140b454f82fbf6c58d77e772a95acc32f487019b3b4ff5cc852d9/merged",
                "UpperDir": "/var/lib/docker/overlay2/64ff7d647da140b454f82fbf6c58d77e772a95acc32f487019b3b4ff5cc852d9/diff",
                "WorkDir": "/var/lib/docker/overlay2/64ff7d647da140b454f82fbf6c58d77e772a95acc32f487019b3b4ff5cc852d9/work"
            },
            "Name": "overlay2"
        },
        "RootFS": {
            "Type": "layers",
            "Layers": [
                "sha256:24a48d4af45bab05d8712fe22abec5761a7781283500e32e34bdff5798c09399",
                "sha256:2c6174552f2d5ec9ae8cb3d216f8a29452518e41fe74851fcd0957bd18598986",
                "sha256:f596047abbb18e543e23e4c81787201ac14ba67ce34200042d6c72169b6fb3e7",
                "sha256:c657acc34742e6c0b6999047a54ff470a79e17098aab735a157c64cbc5194ee4",
                "sha256:b34652bd3230ef29764b05ab651c79441c14e96706f6a0f709db302b53db8a9f",
                "sha256:f136b48635123db05ea486e54fd96067d28be71986467192d471c21f9e7ea24b",
                "sha256:5f70bf18a086007016e948b04aed3b82103a36bea41755b6cddfaf10ace3c6ef"
            ]
        },
        "Metadata": {
            "LastTagTime": "0001-01-01T00:00:00Z"
        }
    }
]