RasaHQ / rasa-sdk

SDK for the development of custom actions for Rasa
https://rasa.com/docs
Apache License 2.0
292 stars 233 forks source link

ENG-1235: Enable triggering release-tagging workflow manually on-demand also #1142

Closed AsadHasan-Rasa closed 3 weeks ago

AsadHasan-Rasa commented 3 weeks ago

Proposed changes: Enable triggering release-tagging workflow manually on-demand also, in case previous auto-run(s) had failed, and we want to re-run on existing prepared-release- branch.

Status (please check what you already did):

sanchariGr commented 3 weeks ago

@AsadHasan-Rasa can you also please remove env.IS_TAG_BUILD from The notify success and failure notifications here?

AsadHasan-Rasa commented 3 weeks ago

@AsadHasan-Rasa can you also please remove env.IS_TAG_BUILD from The notify success and failure notifications here?

Done. If ok, I've also removed env.IS_TAG_BUILD from the failure notification (https://github.com/RasaHQ/rasa-sdk/blob/main/.github/workflows/release-artifacts.yml#L157), because iiuc the same pattern applies there also, and we want to be consistent?