search

RasaHQ / rasa-x-helm

Rasa Enterprise Helm chart for deploying on Kubernetes (K8s) and OpenShift.
Apache License 2.0
76 stars 104 forks source link

Add support to the new IngressClassName spec #263

Closed pierluigilenoci closed 2 years ago

pierluigilenoci commented 2 years ago

Since K8s 1.18 the annotation kubernetes.io/ingress.class is deprecated. It would be very useful to have support for the new IngressClassName spec inside the chart.

Ref: https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/#deprecating-the-ingress-class-annotation

sara-tagger commented 2 years ago

Thanks for raising this issue, @pythenry will get back to you about it soon✨

Please also check out the docs and the forum in case your issue was raised there too 🤗
pierluigilenoci commented 2 years ago

@virtualroot I got to check out the update just today.

Thanks for the work but there is still a small step away. The ingress for RasaX is left out. Ref: https://github.com/RasaHQ/rasa-x-helm/blob/main/charts/rasa-x/templates/rasa-x-ingress.yaml

I created a new ticket for that #270