RasaHQ / rasa

💬 Open source machine learning framework to automate text- and voice-based conversations: NLU, dialogue management, connect to Slack, Facebook, and more - Create chatbots and voice assistants
https://rasa.com/docs/rasa/
Apache License 2.0
18.91k stars 4.63k forks source link

Review allow single token to be annotated by multiple entities in test stories and port to 3.0 #10780

Closed JEM-Mosig closed 2 years ago

JEM-Mosig commented 2 years ago

Follow up to https://github.com/RasaHQ/rasa/issues/10451#issue-1070474320

Definition of Done

TyDunn commented 2 years ago

@JEM-Mosig What are the expectations here?

JEM-Mosig commented 2 years ago

As discussed with @tayfun, and described in the previous issue, https://github.com/RasaHQ/rasa/issues/10451#issue-1070474320, Atom needs to review the PR and port it to 3.0. It's technically all non-research codebase, but it can still affect policies in a way, so I make sure the regression tests run through fine.

TyDunn commented 2 years ago

@JEM-Mosig Are you able to port this to 3.0 and cut a micro release? Or do you need help?

JEM-Mosig commented 2 years ago

Yes, I could do the port if necessary

TyDunn commented 2 years ago

Okay. Since you implemented the 2.8 fix, I think it makes sense for you to follow through with porting + releasing a micro after Tayfun reviews

JEM-Mosig commented 2 years ago

It's all merged into 2.8.x now. Last thing left to do is to port to 3.x

aeshky commented 2 years ago

@JEM-Mosig Just following up on this issue:

  1. Will porting to 3.x be addressed in a separate issue?
  2. Do we need to cut a micro release for this fix?