Closed Urkem closed 11 months ago
@ancalita The validation itself seems to fail on financial llm demo bot... (the flows got loaded. Still not sure if the flow name is a required field for a flow)
The training works if I do skip validation (this does not skip checking the schema):
The validation itself seems to fail on financial llm demo bot
I think that's because pattern_code_change
is missing a name
, I think this should be part of the schema and should be mandatory, in which case schema validation should fail.
I think that's because
pattern_code_change
is missing aname
, I think this should be part of the schema and should be mandatory, in which case schema validation should fail.
Added name as required and pattern_code_change
is a part of OSS so I updated it accordingly.
@twerkmeister @ancalita running the e2e tests on the demo bot (with the default flow change and without the change) is 50pass 18fail always is that the expected ratio or do all tests pass?
Rasa Version : 3.8.0a11
Minimum Compatible Version: 3.5.0
Rasa SDK Version : 3.8.0a1
Python Version : 3.10.10
Operating System : macOS-13.6-arm64-arm-64bit
Python Path : /Users/urosmilovanovic/.pyenv/versions/3.10.10/envs/dm2-1-demo/bin/python
Rasa Plus Version : 3.8.0a11
🚀 A preview of the docs have been deployed at the following URL: https://12901--rasahq-docs-rasa-v2.netlify.app/docs/rasa
Kudos, SonarCloud Quality Gate passed!
5 Bugs
0 Vulnerabilities
1 Security Hotspot
49 Code Smells
0.0% Coverage
0.9% Duplication
The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here
@twerkmeister @ancalita running the e2e tests on the demo bot (with the default flow change and without the change) is 50pass 18fail always is that the expected ratio or do all tests pass?
Hey @Urkem Apologies, I missed this message on Friday, if the same tests fail without the schema change, I'd advise to open a ticket with the details about failing tests and alert Dan about it, should be investigated what change caused those tests to fail since the tests labelled as passing
always passed (68 out of 68).
Proposed changes:
Status (please check what you already did):
black
(please check Readme for instructions)