Disallow dialogue stack slot from being set in custom actions & mark builtin slots

RasaHQ / rasa

💬 Open source machine learning framework to automate text- and voice-based conversations: NLU, dialogue management, connect to Slack, Facebook, and more - Create chatbots and voice assistants

https://rasa.com/docs/rasa/

Apache License 2.0

18.61k stars 4.6k forks source link

Disallow dialogue stack slot from being set in custom actions & mark builtin slots #12917

Closed ancalita closed 11 months ago

ancalita commented 11 months ago

Proposed changes:

Implements ATO-1624

Status (please check what you already did):

[x] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

ancalita commented 11 months ago

Some built-in slots should be writable.

I guess it depends on how the new property marker is_builtin will be used in the future. I'll document somewhere that this property captures both writable and read-only builtin slots (perhaps in the slot module).

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!

5 Bugs
0 Vulnerabilities
3 Security Hotspots
52 Code Smells

0.0% Coverage
0.9% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Read more here