search

RasaHQ / rasa

💬 Open source machine learning framework to automate text- and voice-based conversations: NLU, dialogue management, connect to Slack, Facebook, and more - Create chatbots and voice assistants
https://rasa.com/docs/rasa/
Apache License 2.0
18.27k stars 4.56k forks source link

"await" is missing #13027

Open muxa-xoma opened 3 months ago

muxa-xoma commented 3 months ago

https://github.com/RasaHQ/rasa/blob/7807b19ad5fffab73ca1a04dc710f812115a9288/rasa/core/channels/socketio.py#L230

Missing "await" before sio.enter_room(sid, data[“session_id”])

yousole commented 3 months ago

When session_persistence is set to true, SocketIO cannot reply properly. sio.enter_room(sid, data["session_id"]) needs to be changed to await sio.enter_room(sid, data["session_id"]).