search

RasaHQ / rasa

💬 Open source machine learning framework to automate text- and voice-based conversations: NLU, dialogue management, connect to Slack, Facebook, and more - Create chatbots and voice assistants
https://rasa.com/docs/rasa/
Apache License 2.0
18.56k stars 4.59k forks source link

Interactive Learning: terminal text cutting off if prompt is larger than terminal window #2655

Closed cjcelotto closed 5 years ago

cjcelotto commented 5 years ago

Rasa Core version: 0.11.12

Python version: 3.6.5

Operating system (windows, osx, ...): macOS

Issue: When doing interactive learning, the bolded text the system sends back cuts off if the terminal window is too small. It doesn't wrap to the following line, even if you try to expand the window after. Sometimes it cuts off so much that you have to go back and reset the previous action because you can't tell what intent was triggered. Screenshots below.

screen shot 2018-10-23 at 9 17 44 am screen shot 2018-10-23 at 9 18 02 am screen shot 2018-10-23 at 9 18 10 am screen shot 2018-10-23 at 9 18 34 am screen shot 2018-10-23 at 9 18 47 am screen shot 2018-10-23 at 9 18 55 am
akelad commented 5 years ago

Thanks for raising this issue, @MetcalfeTom will get back to you about it soon.

MetcalfeTom commented 5 years ago

Yup, it's a bug! Seems to be a problem with PyInquirer's prompt. Thanks for bringing this to our attention @cjcelotto, I'll add it to the backlog

Related to this is that textwrap will terminate the script with ValueError: invalid width if the window width is too narrow. Not sure if this is fixable but worth a look into as well.

cjcelotto commented 5 years ago

Awesome! Thank you @akelad and @MetcalfeTom .

Ghostvv commented 5 years ago

I opened the issue in PyInquirer repo: https://github.com/CITGuru/PyInquirer/issues/21

CITGuru commented 5 years ago

@Ghostvv Sorry for late response, this should be fix soon and @cjcelotto

Ghostvv commented 5 years ago

@CITGuru thank you

CITGuru commented 5 years ago

@Ghostvv This has been fixed here https://github.com/CITGuru/PyInquirer/releases/tag/1.0.3

Ghostvv commented 5 years ago

@CITGuru thank you, we'll update our requirements