search

RasaHQ / rasa

💬 Open source machine learning framework to automate text- and voice-based conversations: NLU, dialogue management, connect to Slack, Facebook, and more - Create chatbots and voice assistants
https://rasa.com/docs/rasa/
Apache License 2.0
18.72k stars 4.61k forks source link

Synchronizing Rasa message ID with Teams/BotFramework ID #4585

Closed glaulom closed 1 year ago

glaulom commented 4 years ago

Description of Problem: Actually, messages IDs stored in the database by the tracker store are different from the one generated by Microsoft Teams (through BotFramework). It would be very nice to synchronize both IDs.

Overview of the Solution: Just re-use Teams IDs rather than creating new ones.

Blockers (if relevant): Is BotFramework getting messages ID ?

Definition of Done:

sara-tagger commented 4 years ago

Thanks for submitting this feature request 🚀@dakshvar22 will get back to you about it soon!✨

wochinge commented 4 years ago

@glaulom Is this something you want to work on?

glaulom commented 4 years ago

@wochinge I actually don't have any time to work on this, so it's a proposition to the community.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

pnandhini11 commented 3 years ago

Hi, Is this issue closed? Can I work on this?

wochinge commented 3 years ago

Sure - go for it @pnandhini11 ! 🚀

pnandhini11 commented 3 years ago

Hi @wochinge, In botframework channel, message id (sender_id) that we use for conversation is the ID retrieved from json received in webhook. What exactly in the "FROM ID" in botframework channel? How different that from the Microsoft Teams ID?

Check this:

@botframework_webhook.route("/webhook", methods=["POST"]) async def webhook(request: Request) -> HTTPResponse: postdata = request.json metadata = self.get_metadata(request)

metadata_with_attachments = self.add_attachments_to_metadata( postdata, metadata )

try: if postdata["type"] == "message": out_channel = BotFramework( self.app_id, self.app_password, postdata["conversation"], postdata["recipient"], postdata["serviceUrl"], )

user_msg = UserMessage( text=postdata.get("text", ""), output_channel=out_channel, sender_id=postdata["from"]["id"], input_channel=self.name(), metadata=metadata_with_attachments, )

sync-by-unito[bot] commented 1 year ago

➤ Maxime Verger commented:

:bulb: Heads up! We're moving issues to Jira: https://rasa-open-source.atlassian.net/browse/OSS.

From now on, this Jira board is the place where you can browse (without an account) and create issues (you'll need a free Jira account for that). This GitHub issue has already been migrated to Jira and will be closed on January 9th, 2023. Do not forget to subscribe to the corresponding Jira issue!

:arrow_right: More information in the forum: https://forum.rasa.com/t/migration-of-rasa-oss-issues-to-jira/56569.