💬 Open source machine learning framework to automate text- and voice-based conversations: NLU, dialogue management, connect to Slack, Facebook, and more - Create chatbots and voice assistants
Description of Problem: Sanic needs to be upgrade to address #9167. Until recently the pytest-sanic dependency was blocking this upgrade. This block has been resolved.
The following is largely a list of things that needed to be done for upgrading sanic in rasa-sdk. As rasa oss is more complex, potentially other steps need to be taken as well.
[ ] Sanic.test_mode = True needs to be added in tests/conftest.py
[ ] rasa-sdk dependency is updated to a version that uses sanic 21.6.0 too (potentially the branch intermittently or a v 3.0 release candidate or sth like that)
m-vdb
commented
1 year ago
Description of Problem: Sanic needs to be upgrade to address #9167. Until recently the
pytest-sanicdependency was blocking this upgrade. This block has been resolved.The following is largely a list of things that needed to be done for upgrading sanic in
rasa-sdk. As rasa oss is more complex, potentially other steps need to be taken as well.Definition of Done:
sanicis upgraded to^21.6.0sanic-testingis added as a dev dependencypytest-sanicis upgraded to^1.8.1sanic-corsis upgraded to^1.0.0(there's a naming conflict here as the new package name is upper cased - needed to delete thesanic-corsline by hand first when doing the upgrade inrasa-sdk. Whysanic-corsneeds updating: https://community.sanicframework.org/t/handle-request-exception-after-upgrading-from-20-9-1-to-21-3/835Sanic.test_mode = Trueneeds to be added intests/conftest.pyrasa-sdkdependency is updated to a version that uses sanic 21.6.0 too (potentially the branch intermittently or a v 3.0 release candidate or sth like that)