search

Rasbats / DR_pi

Add DR positions to a route (saved as a GPX file)
GNU General Public License v3.0
2 stars 29 forks source link

FS#2698 - Many plugins cannot compile with new PluginConfigure.cmake requiring to run from a git repo #8

Open dominig opened 4 years ago

dominig commented 4 years ago

FS#2698 - Many plugins cannot compile with new PluginConfigure.cmake requiring to run from a git repo

The new version of PluginConfigure.cmake file written by John Gaugh and reused for several plugins (see list bellow) requires the build to be run fro ma git valid repo. When building packages in the distro system (my case Open Build System from OpenSUSE), the source used for the build is a copy and not a valid git repo, so the cmake fails miserably.

Having at least an option to deactivate that feature to allow and off git build is required.

Could we have a clean solution to by overcome that feature when not needded ?

Thanks.

Dominig

OpenCPN-DR_pi OpenCPN-nmeaconverter_pi OpenCPN-ocpn_draw_pi OpenCPN-photolayer_pi OpenCPN-UKTides_pi OpenCPN-vfkaps_pi

Rasbats commented 4 years ago

Branch 2.1.1-legacy has the same code.

rgleason commented 4 years ago

doming I believe you can set your own repo as you wish in this way, from the CMakeLists.txt file

# The next line allows setup of a local webserver with git for testing purposes.
# The default is shown below, but it is done in cmake/pluginconfigure.cmake now.
# This default is needed to build locally and to build flatpak.
#set(GIT_REPOSITORY_SERVER "github.com")

#No longer needed, queried.
#set(GIT_USER "rgleason")
#set(GIT_REPOSITORY_NAME "testplugin_pi")

I have put these in my version of the testplugin_pi because I understood that they could be used. (Perhaps I have that wrong,, but it would be nice to know.)

https://github.com/rgleason/testplugin_pi

I would just go ahead and try it. Hope this helps. I know Jon used it to set up his own server for github because his internet is so slow.