Rasbats / managed_plugins

Wiki for the leamas managed plugin workflow
Mozilla Public License 2.0
0 stars 3 forks source link

new-credentials - keys could end up in the wrong directory. #38

Closed Rasbats closed 2 years ago

Rasbats commented 2 years ago

Instructions leave the keys in the ci directory.

New ssh key created and encrypted.Todo:

  - Commit the new ssh keys ci/Rasbats.pub and ci/Rasbats.enc.
  - Add the ssh url as GIT_REPO environment variable in builder.
  - Add password as GIT_KEY_PASSWORD environment variable in builder.
  - Add the public key ci/Rasbats.pub below to the github account:

Suggest:

New ssh key created and encrypted.Todo:
  - Move the ssh keys ci/Rasbats.pub and ci/Rasbats.enc to the build-deps directory.
  - Commit the keys Rasbats.pub and Rasbats.enc.
  - Add the ssh url as GIT_REPO environment variable in builder.
  - Add password as GIT_KEY_PASSWORD environment variable in builder.
  - Add the public key ci/Rasbats.pub below to the github account:
leamas commented 2 years ago

Isn't this two questions?

leamas commented 2 years ago

When I make a try, new-credentials actually stores the key in build-deps in both master and v3.0 branch. Have you any other experiences?

If so, this is just a simple documentation fix: replace ci with _build-deps-, I guess. Or?

Rasbats commented 2 years ago

My mistake - TideFinder_pi has not been updated.