RashKash103 / custom-gridfinity-bins

Create custom Gridfinity divider bins using a Python script.
7 stars 4 forks source link

Wall at finger scoop #1

Open bitranox opened 2 years ago

bitranox commented 2 years ago

Dear Rash, good job ! there is one issue :

if You set

DRAW_FINGER_SCOOP = False
DRAW_LABEL_LEDGE = True

the wall were the finger scoop should be located, is too thick, compared to the other 3 walls. It would be good if You can fix that.

the requirements.txt is not correct for windows installations - should I send You a PR ?

yours sincerely

bitranox Vienna.

RashKash103 commented 2 years ago

I will have a look at that and see what might be causing the issue.

Thanks for opening up a PR on the Windows requirements!

RashKash103 commented 2 years ago

@bitranox – so looking into the code, I realized that it was a design decision that I made to make the front wall thicker, even if the finger scoop was disabled. This is what it currently looks like:

Current front wall picture

And you're requesting to make it look like this:

Proposed front wall picture

I believe that if that is what you proposed, it might be difficult to lift up items using the front surface as leverage since they would get stuck on the lip. This is especially noticeable when using smaller sections because you don't need leverage to lift up components from a larger section. Therefore, that is intended behavior.

That being said, I will work on adding a configuration option to remove that padding if the finger scoops are disabled.

bitranox commented 2 years ago

Dear RashCash, first of all - great work and thank You for Your kind response!

I believe that if that is what you proposed, it might be difficult to lift up items using the front surface as leverage since they would get stuck on the lip.

Absolutely true for smaller Trays - I have some trays where that does not matter, so it is a waste of material. You can also make the angle of the lower chamfer on the front lip a bit less steep to ease that problem.

proposed Settings :

# FRONT Lip lower chamfer angle, between 0 and 60 degrees for easy parts removal
# the lower the angle, the easier to extract and pour out, but needs more material. Default = 45 degrees
# this setting applies only to the front lip and makes only sense when FRONT_WALL_PADDING = False
LIP_FRONT_LOWER_CHAMFER_DEG = 30

# Lip lower chamfer angle, between 0 and 60 degrees for easy parts pouring out on small parts
# the lower the angle, the easier to pour out, but needs more material. Default = 45 degrees
# this setting applies to all lips, except the front lip
LIP_LOWER_CHAMFER_DEG = 45

# make FRONT wall thicker to match the Lips nose - for easy parts removal, but needs more material, 
# Default = True
# this setting applies only to the front wall and only makes sense when DRAW_FINGER_SCOOP = False
FRONT_WALL_PADDING = False           

# make wall thicker to match the Lips nose - for easy parts pouring on very small parts, but needs more material
# Default = False
# this setting applies to all walls, except the front wall.
WALL_PADDING = False           

the drawings You made are nice - lets put them to the readme section to explain the settings ?

and lets rename, that would be the correct terminus technicus :

# The number of Gridfinity units long (front to back)
UNITS_LONG = 1
# to 
# The number of Gridfinity units depth (front to back)
UNITS_DEPTH = 1

If You want to integrate, I can make more PR´s for testing, clean CLI Interface, correct typing, etc ...

again - great work !

yours sincerely

Robert

bitranox commented 2 years ago

Dear RashCash, are You working on it ? Or should I ... ? yours sincerely Robert