search

Rashmi-K-A / chaoss-sortinghat

This is a repo for completing the microtasks mentioned at https://github.com/chaoss/grimoirelab/issues/415
0 stars 0 forks source link

Review Microtask 5 #2

Closed Rashmi-K-A closed 3 years ago

Rashmi-K-A commented 3 years ago

Task: Create a sample profile with different identities and enrollments using the SortingHat UI. Link: https://github.com/Rashmi-K-A/chaoss-sortinghat/blob/master/Microtask5.md

vchrombie commented 3 years ago

Thanks for your effort in trying the task both in sortinghat new version and also hatstall. The task looks good to me.

But, I see you worked on a different example. We have provided an example in the microtask list to test all the cases.

The current task looks fine but it would be great if you add a screenshot of this profile too, only if you have time. Not a compulsion, but good to have it. You can just add the sortinghat version, hatstall is not needed.

Thanks again.

Rashmi-K-A commented 3 years ago

Oh no! I don't know how I didn't realize thats the example I have to implement. I kept thinking just because its on the UI, this picture was there. Such a silly mistake. Sure! Let me do that, and I'll update the task with the right example if I have time too.

vchrombie commented 3 years ago

Oh no! I don't know how I didn't realize thats the example I have to implement. I kept thinking just because its on the UI, this picture was there. Such a silly mistake.

No issues :smile:.

Sure! Let me do that, and I'll update the task with the right example if I have time too.

Thanks!

Rashmi-K-A commented 3 years ago

@vchrombie I added a screenshot for the above profile with multiple identities, please take a look

vchrombie commented 3 years ago

LGTM! Thanks for the effort.