search

RasmusTidselbak / al-var-helper

6 stars 7 forks source link

Casing issues #10

Closed jwikman closed 5 years ago

jwikman commented 5 years ago

I've noticed a few places where the "Fix casing" changes casing in the wrong way:

  1. In Page object, "action(" element changes to "Action(", should remain "action" (I guess that it matches for Action::LookupOK)

  2. In Page object, SourceTableView property, "SORTING" should change to "sorting", does not change

  3. In Report object, DataItemTableView property, "SORTING" should change to "sorting", does not change

  4. In Page object, SourceTableView property, "where" changes to "Where", shoud be "where"

  5. "STRSUBSTNO" changes to "StrSubStNo", should be "StrSubstNo"

  6. "RecordId" changes to "RecordID", should stay "RecordId"

  7. "RecRef.Field" changes to "RecRef.field", should stay "RecRef.Field"

  8. Datatype "label" should be changed to "Label"

  9. "Next" as a value in an option string becomes "Next()", should stay as "Next (this one has resulted in really strange errors): procedure SetColumns(SetWanted: Option Initial,Previous,Same,Next,PreviousColumn,NextColumn); and ActionChangePeriods(gSetWanted::Next); becomes procedure SetColumns(SetWanted: Option Initial,Previous,Same,Next(),PreviousColumn,NextColumn); and ActionChangePeriods(gSetWanted::Next());

  10. "modify" in a Page Extension layout changes to "Modify", should stay "modify" layout { Modify("Job No.") should stay layout { modify("Job No.")

  11. Page field TableRelation "where" changes to "Where", should stay "where" TableRelation = Job Where ("Whatever" = field ("Whatever"));

  12. Report DataItemTableView "where" changes to "Where", should stay "where"

  13. "downto" in for statement changes to "DownTo", should stay "downto"

  14. "COPYSTR" should change to "CopyStr", does not change

  15. "EVALUATE" should change to "Evaluate", does not change

  16. "SELECTSTR" should change to "SelectStr", does not change

  17. "PageVariable.EDITABLE" should change to "PageVariable.Editable", does not change

  18. "Record.CALCSUMS" should change to "Record.CalcSums", does not change

  19. "FIELDERROR(" should change to "FieldError("

  20. "ROUND(" should change to "Round("

That was what I found in my code right now, but I got the feeling that it's even more. ;-)

But overall it's doing a great job!

Maybe you should look into fin.stx to find all keyword that might need to be changed?

RasmusTidselbak commented 5 years ago

I'll look into it, thanks alot for the very thorough description :)

jwikman commented 5 years ago
  1. "FIELDCAPTION" should change to "FieldCaption" :)