Closed jmtsuji closed 2 years ago
Hi Jackson
Thanks for reporting this and your suggestion. I tested your solution and it resolved the issue, so I will update the Master asap :) Please let me know if it's not working in your env.
Best, Joachim
Thanks @joacjo !
Thanks for making this helpful viral binning tool! I have a minor request to improve the usability of the python scripts in the
phamb
directory, based on an issue I ran into while running the test data for phamb. See below:Problem description
Using phamb 1.0.1, installed via conda on a linux server, I got the following error when running the test command:
Command:
Error:
Possible causes
I think the issue is caused by the shebang line in
phamb/run_RF.py
:Because I am running phamb in a conda env, my
python
is located in${CONDA_PREFIX}/bin/python
. I'm running a very clean system and don't have python installed globally.Proposed solution
Change the shebang line of
phamb/run_RF.py
to a more universal shebang (discussed here):Similarly,
phamb/run_RF_modules.py
andphamb/split_contigs.py
could be changed to use the same shebang (they are currently using#!/bin/python
).I'm happy to make a PR for this minor change, if it helps. Thanks again!