Closed lwalter86 closed 8 years ago
We need to wonder if we still want to use Led
class from pingo.parts.led
https://github.com/pingo-io/pingo-py/blob/master/pingo/parts/led.py or have our own Led
class.
Will we use threading.Thread
to manage blinking led for example ? not sure that's a great idea. We might follow KISS principle. No threading might help.
After making our own non-threading Led
class we might be able to merge code from pingo.parts.led
to ours and provide a non threading and a threading class for Led (with a similar interface but with a different implementation) and submit a PR to pingo
We need to use threading because we want led blinking while waiting for another card (after passing a master card for example).
green Led is turned on while the door is open Led blinking seems not to work as we want
SMYC ;-)
You should make a branch and we will merge it when it will be fixed
See the branch Led_management The time sleep in readers.py seems to fix this issue but this needs to be confirmed.
Nice to see this branch merged!
Need to implement led management