Closed chrisroos closed 3 months ago
Thanks @floehopper. Would you mind reviewing/approving it again now that I've addressed your comments, please? I've made the following changes since your last review:
admin_schools_path
helper method in the commit titled "Add tests for Admin::SchoolsController"
This is mostly a refactoring PR in preparation for creating a school in Profile API upon verification in Editor API. Once we're creating schools in Profile API we'll need to keep them in sync with the data in Editor API. To make that easier this PR restricts a verified school from being rejected so that we don't have to handle updating/deleting schools in Profile API (at least for now).
This PR also:
verified_at
orrejected_at
set at a time, and so that once set those values can't be changed.SchoolVerificationService#verify
whereby a failed verification would appear to have been successful to the user.