RaspberryPiFoundation / editor-ui

Code Editor web component
https://editor-static.raspberrypi.org
Apache License 2.0
36 stars 9 forks source link

Integration: Save / Login functionality not as expected #843

Open maxelkins opened 9 months ago

maxelkins commented 9 months ago

Current behaviour:

As a non-logged user:

  1. Click log in to save
  2. Logged in
  3. Need to click save again to save project.

Expected:

As a non-logged user:

  1. Click log in to save
  2. User logged in and Project is auto-remixed (user doesn't need to click save)
create-issue-branch[bot] commented 9 months ago

Branch issues/843-IntegrationSave/_Login_functionality_not_as_expected created!

sra405 commented 8 months ago

Pushed back to allow room to test and release separately. Currently it intermittently causes multiple auto remixes and blocks the editor loading via the web component. Most of the time it works great and provides a 1-to-1 auto remixing/fetching functionality but needs to be monitored during rollout.

maxelkins commented 8 months ago

Save button added back in for now https://github.com/RaspberryPiFoundation/editor-ui/pull/872

Please could we keep this ticket open though, as it would be good to pick up again when we have more time.

sra405 commented 8 months ago

Please could we keep this ticket open though, as it would be good to pick up again when we have more time.

Yea no worries, it's still open and on a sprint board 👍

sra405 commented 7 months ago

removing from integration beta milestone as its part of normal BAU/bugs backlog

MFarringtonRPF commented 3 days ago

Propose to close this ticket, as it's covered in https://github.com/RaspberryPiFoundation/editor-standalone/issues/190