Tweaks to Web Component

[magdalenajadach]

Closing: https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/138

[github-actions[bot]]

• Github Run 8264282965
• Test coverage: 78%

[github-actions[bot]]

• Github Run 8283539654
• Test coverage: 78%

[github-actions[bot]]

• Github Run 8283657294
• Test coverage: 78%

[github-actions[bot]]

• Github Run 8284053625
• Test coverage: 78%

[github-actions[bot]]

• Github Run 8294615076
• Test coverage: 78%

[github-actions[bot]]

• Github Run 8294996947
• Test coverage: 78%

[github-actions[bot]]

• Github Run 8295152841
• Test coverage: 78%

[loiswells97]

Looks like some of the styles are still missing, for example, the coloured underline beneath selected tab, the colours for the selected tab in the sidebar, download icon in dark mode, settings ticks in dark mode against the teal background should be black. Also, if we're having the default theme colour being teal, then I think we need to think about whether the buttons need to default to teal as well rather than blue 🤔

[github-actions[bot]]

• Github Run 8295649767
• Test coverage: 78%

[github-actions[bot]]

• Github Run 8295659312
• Test coverage: 78%

[magdalenajadach]

@loiswells97 Those findings are all known. I should flag it before the review. So the issue is with theming between Projects Site embedded WC, standalone WC and Editor. When applying this teal color we encountered loads of issues with styling and themes. Since we don't yet have a very clear vision of dark mode for the standalone WC we decided to push it as it is, since the Standalone in a light (default) mode was not usable for online courses. So long story short it's an update and progress, but not yet for the dark mode due to theming shenanigans.

[github-actions[bot]]

• Github Run 8296023002
• Test coverage: 78%

[loiswells97]

@loiswells97 Those findings are all known. I should flag it before the review. So the issue is with theming between Projects Site embedded WC, standalone WC and Editor. When applying this teal color we encountered loads of issues with styling and themes. Since we don't yet have a very clear vision of dark mode for the standalone WC we decided to push it as it is, since the Standalone in a light (default) mode was not usable for online courses. So long story short it's an update and progress, but not yet for the dark mode due to theming shenanigans.

Ah I see, in that case, I'm happy to approve - as you say, it's an improvement that should make it usable in light mode for the online courses at least 👍

[github-actions[bot]]

• Github Run 8326955530
• Test coverage: 78%

[magdalenajadach]

I managed to fix most of the issues with dark mode, removed peasky teal.

I achieved that overrriding some styles within InternalStyles.scss - it's not impacting Editor or Projectst site.

Still left some commenst to flag up what I have done.

[magdalenajadach]