Remove broken `format` script

RaspberryPiFoundation / editor-ui

Code Editor web component

https://editor-static.raspberrypi.org

Apache License 2.0

36 stars 9 forks source link

Remove broken `format` script #991

Closed floehopper closed 5 months ago

floehopper commented 5 months ago

This script is broken, because no .prettierrc file is included in the repo.

We're relying on the prettier plugin for eslint to do code formatting & checking, e.g. in .github/workflows/ci-cd.yml where we invoke yarn lint to check the formatting.

Similarly, the lint:fix script can be used to apply formatting. So the format script is redundant and potentially confusing to new developers.

github-actions[bot] commented 5 months ago

Github Run 8836481588
Test coverage: 77%

github-actions[bot] commented 5 months ago

Github Run 8836536611
Test coverage: 77%

github-actions[bot] commented 5 months ago

Github Run 8875152139
Test coverage: 77%

floehopper commented 5 months ago

LGTM

Thanks, @danhalson. I seem to have lost your review approval by rebasing the branch and fixing the conflicts. Any chance you could re-add it?