search

RaspberryPiFoundation / lesson_format

Lesson formatter
18 stars 28 forks source link

Header banner on lesson PDFs is borked for “additional projects” #118

Closed andylolz closed 9 years ago

andylolz commented 9 years ago

screen shot 2014-11-28 at 09 04 45

The green box was originally there to contain the level (where each term contained multiple levels.) I don’t think we’re using the concept of levels anymore. Does the box still need to be there? Perhaps it should just be removed from “additional projects”?

What do you think, @CodeClubRik?

rikcross commented 9 years ago

Yep I agree -- It certainly doesn't need to be there for additional projects, but it may be useful to indicate somewhere that a particular project isn't in the core curriculum.

andylolz commented 9 years ago

indicate somewhere that a particular project isn't in the core curriculum

Sounds like something for the website and not for the PDF version (i.e. volunteer-facing, not student-facing). What do you think?

Removing the box looks weird. I am not a designer. screen shot 2014-11-28 at 10 09 31

Maybe this? screen shot 2014-11-28 at 10 42 47

rikcross commented 9 years ago

Sure! But don't hard-code the word 'Term', as the names for the 'terms' will change :) I guess we could just update the 'level' in the project markdown to say 'term +'?

andylolz commented 9 years ago

Additionally, I’d suggest removing the level indicators for each project from the term page. i.e. these things: screen shot 2014-11-28 at 10 50 25 Now that they’re just repeating the term number, they’re not really needed.

rikcross commented 9 years ago

Yeah I agree -- but it should stay here? screen shot 2014-11-28 at 10 55 42

andylolz commented 9 years ago

I guess we could just update the 'level' in the project markdown to say 'term +'?

The effect you see above was achieved using that very technique! :)

rikcross commented 9 years ago

:+1:

andylolz commented 9 years ago

but it should stay here?

I think so, yep. Life is much easier, though, the text used is the same as the PDF version, e.g.: screen shot 2014-11-28 at 11 06 25

rikcross commented 9 years ago

Awesome. I'll rename 'additional projects' 'term +' and commit. How about while I'm at it I change the names to 'Scratch 1/2/+', as 'Scratch +' reads better than 'Term +', which doesn't make a lot of sense.

andylolz commented 9 years ago

Awesome. I'll rename 'additional projects' 'term +' and commit.

Cool. I’ll push a change that will make that render correctly.

How about while I'm at it I change the names to 'Scratch 1/2/+', as 'Scratch +' reads better than 'Term +', which doesn't make a lot of sense.

The short version: Yes, I agree.

The long version: There used to be an explicit ordering on when to do each language (scratch terms 1&2, web term 3, python term 4). This doesn’t appear to really exist anymore… Is that true? Are the language curricula intended to be (or become) independent of one another? If that’s really the case, then I agree that 'Scratch 1/2/+' (and 'Python 1/2/+') does make more sense.

Sorry – this turned into a bit of a wider question!

rikcross commented 9 years ago

OK I've just pushed the changes above.

As for the ordering of projects, there will be 'suggest routes' through our resources soon, which will take into account the length of time that the club will run!

andylolz commented 9 years ago

I think this is fixed now :rocket:

Thanks, @CodeClubRik!

andylolz commented 9 years ago

Wait WAT

screen shot 2014-12-16 at 13 13 18

Sigh…