RaspberryPiFoundation / lesson_format

Lesson formatter
17 stars 28 forks source link

Switch to using ddollar/heroku-buildpack-multi #179

Closed andylolz closed 8 years ago

andylolz commented 8 years ago

https://github.com/andylolz/heroku-buildpack-python-extras appears to be broken now. Rather than fix it, it’s probably better to switch to use https://github.com/ddollar/heroku-buildpack-multi

Here are the steps to doing this:

NB The python buildpack happens to run bin/post_compile, which is really handy because lesson_format utilises this. So as long as the python buildpack is last in the .buildpacks file, this works (since bin/post_compile is dependent on stuff in the other two buildpacks). I am noting this here because it seems like something that could break in the future.

Fixes (well, hopefully) #178.

martinpeck commented 8 years ago

I was going to try taking the buildback from which you based yours (https://github.com/localmed/heroku-buildpack-python-extras) and seeing if that worked. Do you think that's going to be broken in similar ways?

andylolz commented 8 years ago

Do you think that's going to be broken in similar ways?

Similar ways, plus more ways as well.

But anyway, this ddollar/heroku-buildpack-multi is a much more robust solution. And ddollar is was a heroku person anyway (creator of foreman by the looks of things).

martinpeck commented 8 years ago

So, this worked fine on a new heroku app, but failed on the existing one.

martinpeck commented 8 years ago

wait...hold that thought I'm an idiot...

martinpeck commented 8 years ago

Idiot status confirmed. Deployment worked fine. Thanks @andylolz!

andylolz commented 8 years ago

Great! :)